Skip to main content


Small UX improvements for the Frio theme


I like the Frio theme, but some things are not convenient for me, especially on mobile, so I decided to suggest some improvements. That's the beauty of open-source! I hope I didn't mess anything up and you'll like the changes :)

https://github.com/friendica/friendica/pull/12699

!Friendica Developers

reshared this

in reply to Damian Wajer

@Damian Wajer wow, that's super cool to read! just today someone asked me about how I customized the theme of my friendica instance and I shared with him this link where community themes can be collected: https://git.friendi.ca/aaron/themes-community
in reply to Damian Wajer

@Damian Wajer Very nice. What do you think about making the "link to source" link for each post and comment open in a new tab/window with target="_blank" in the <a> HTML?

Friendica Developers reshared this.

in reply to Jeremy [Friendica]

@Jeremy [Friendica] To answer that, I'd like to start with some theory. Please note that there are different views on this, and this is just my opinion. In general, it's best to let the user decide and not force a new window/tab. If you put `target="_blank"` in the code, you take away the user's freedom of choice and force an arbitrary solution (the user can't open the link in the same tab).

However, there are some exceptions, such as when leaving the current tab would result in the loss of the user's work, e.g. form content not submitted/lost.
There are also "marketing" reasons, where leaving the site will interrupt your analytics session.

Anyway, to the point. You are asking about specific "link to source" link, represented by the icon with an outward arrow. It may suggest opening in a new tab, which is not the case. It can be confusing for the user who expects new tab based on the icon appearance (it can lead to abandoning "in progress" task). So in this specific case, I think it would be justified to add `target="_blank"`.

reshared this

in reply to Damian Wajer

This is such an obvious improvement it is really great that you picked it as your first contribution.

One area I always was wondering why I have to do the mouse sport thing to click into a tiny circle instead of just being able to click on the section / info text to pick an option was the contact request dialog (the one you see when others request to follow you). I think that was not part of your PR. Would you be willing to extend clickable areas for that?
This entry was edited (1 year ago)

Friendica Developers reshared this.

in reply to Wilhelm

@Wilhelm I'm glad you like it! :)

As for the contact request dialog, it was not part of my PR, because my account automatically approves contact requests, and I wasn't aware of that dialog. I will look at it, but I can't make promises. Could you please provide a screenshot of what exactly you mean? It will help me find it and make an improvement. The best place to put it would be a new issue on GitHub: https://github.com/friendica/friendica/issues

@Hypolite Petovan Do you know if there is an easy way to trigger that view without having the second account for testing purposes? I have one, but it seems like once we were friends, it won't show up again. You can also point me to the right `.tpl` file, maybe that will be enough.

Friendica Developers reshared this.

in reply to Damian Wajer

@Damian Wajer I'm not sure what @Wilhelm is referencing so I'm working with him in order to provide a screenshot.

Also my condolences for the attention you attracted with your first PR. Friendica doesn't have a resident frontend contributor, so you're like the messiah.

Friendica Developers reshared this.

in reply to Hypolite Petovan

@Hypolite Petovan Thanks for caring, but no problem. I use various open-source software for most of my life, so I'm glad I can help and give something back to the community. I already have the plan to make at least one more PR (maybe more to make them more granular), so I'm open to any suggestions – within the scope of a new Friendica user ;)

Friendica Developers reshared this.

in reply to Wilhelm

@Wilhelm@Hypolite Petovan It turned out to be a bug to fix, not a new feature to add. Anyway, good news! I've fixed it in this PR: https://github.com/friendica/friendica/pull/12730 :)
in reply to Damian Wajer

@Damian Wajer Thanks so much for digging into this one! Your fix is highly appreciated.

Friendica Developers reshared this.

in reply to Damian Wajer

It is nice to see that someone works on the Frio theme, I use this since it was first released, I really like it, but it is not perfect, I like that it is receiving some improvements.

Not sure who else works/worked on it, thanks to all other people too.

Friendica Developers reshared this.